[PATCH v2 08/14] OdevAttribute: Remove unowned flag from OdevAttributes head

Hans de Goede hdegoede at redhat.com
Tue Feb 11 09:56:58 CET 2014


Hi,

On 02/11/2014 06:55 AM, Peter Hutterer wrote:
> On Tue, Feb 04, 2014 at 12:49:14PM +0100, Hans de Goede wrote:
>> The OdevAttributes struct should just be a head of the attributes list, and
>> not contain various unrelated flags. Instead add a flags field to
>> struct xf86_platform_device and use that.
> 
> You just introduced int-type attributes, any reason you didn't just move
> this into an attribute?

Because it is a server internal thing, not a constant value (as all other
attributes are), and because having a flags field is also quite useful for
later changes, for keeping track of the dri node being paused or not
(which again is a server internal non const value).

Regards,

Hans


More information about the xorg-devel mailing list