[PATCH] Add check for link from output to crtc before optimizing out a CrtcSet call

[Keith Packard]

David Sodman <dsodman at chromium.org> writes:

> The function RRCrtcSet call checks to see if the config being set is
> already configured, but, doesn't check that the selected outputs are
> connected to the crtc before skipping.  This means that the following
> sequence will omit the final CrtcSet call to the driver:
>
>     CRTC c1 connect to output o
>     CRTC c2 connect to output o
>     CRTC c1 connect to output o
>
> This change adds the check to ensure that each of the calls are made to
> the driver.
>
> Signed-off-by: David Sodman <dsodman at chromium.org>
> Reviewed-by: Stephane Marchesin <marcheu at chromium.org>

This generates a warning:

 CC       rrcrtc.lo
rrcrtc.c: In function 'RRCrtcSet':
rrcrtc.c:618:17: warning: declaration of 'o' shadows a previous local [-Wshadow]
             int o;
                 ^
rrcrtc.c:526:9: warning: shadowed declaration is here [-Wshadow]
     int  o;
         ^

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140207/431328ec/attachment.pgp>