[PATCH 2/5] miinitext: drop sentinel detection during LoadExtension

Keith Packard keithp at keithp.com
Fri Feb 7 15:52:54 PST 2014


Emil Velikov <emil.l.velikov at gmail.com> writes:

> All the sentinels from the extension lists were removed, thus the only
> case were this would trigger is when the code is broken badly.

(given the remaining restructuring coming, this is fine; in general,
this should probably be an assert failure just in case someone outside
the X server is doing something wrong...)

Reviewed-by: Keith Packard <keithp at keithp.com>

>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>  mi/miinitext.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/mi/miinitext.c b/mi/miinitext.c
> index 9d5125e..099ac42 100644
> --- a/mi/miinitext.c
> +++ b/mi/miinitext.c
> @@ -369,9 +369,6 @@ LoadExtension(const ExtensionModule * e, Bool builtin)
>  {
>      ExtensionModule *newext;
>  
> -    if (e == NULL || e->name == NULL)
> -        return;
> -
>      /* Make sure built-in extensions get added to the list before those
>       * in modules. */
>      AddStaticExtensions();
> -- 
> 1.8.5.2
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140207/67f06c54/attachment.pgp>


More information about the xorg-devel mailing list