[PATCH 5/8] glamor: Promote the screen pixmap to a texture when it starts as MEMORY.

Keith Packard keithp at keithp.com
Thu Feb 6 16:15:15 PST 2014


Eric Anholt <eric at anholt.net> writes:

> If you're building a new X Server and trying to light up glamor, one
> of the first things you want to do is get it rendering the screen to a
> texture so you can later draw that to some real output (or possibly
> not draw it at all, if it's Xvfb-like).  Don't just leave it in a
> segfaulting MEMORY state.

This smashes pixmap->devPrivate.ptr, which was pointing at pixmap
memory.  Ephyr keeps running because it saves another copy of this
pointer elsewhere, but I don't think glamor should count on that.

I think ephyr should have a special CreateScreenResources for glamor
mode that creates a real glamor pixmap and uses that. Then, it shouldn't
be setting the fb parameters in ephyrMapFramebuffer.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140206/f7e18508/attachment.pgp>


More information about the xorg-devel mailing list