[PATCH] os: remove unused typedef for "string"

Peter Hutterer peter.hutterer at who-t.net
Wed Feb 5 15:38:37 PST 2014


On Wed, Feb 05, 2014 at 03:22:03PM -0800, Alan Coopersmith wrote:
> On 02/ 5/14 02:05 PM, Peter Hutterer wrote:
> >--- a/os/connection.c
> >+++ b/os/connection.c
> >@@ -117,7 +117,6 @@ SOFTWARE.
> >
> >  #ifdef XSERVER_DTRACE
> >  #include <sys/types.h>
> >-typedef const char *string;
> 
> Sorry, but we need it on Solaris at least, since the dix/Xserver-dtrace.h
> generated by the dtrace command during the build refers to the string type.
> 
> We could wrap it in #ifdef __sun I guess, if that helps.  (Apple seems to
> already have #define for it in dix/Xserver.d, not sure if BSD needs it or
> not.)

ah, that explains why I couldn't find it then. Just consider the patch
withdrawn, it's localised enough that it shouldn't cause an issues.

Cheers,
   Peter


More information about the xorg-devel mailing list