[PULL] button mapping fix and unconstify patches

[Gaetan Nadon]

On 14-02-05 03:25 AM, Keith Packard wrote:
> With this hidesight, I think now what I should have done is to cast at
> the assignment of the string constant and leave the types alone. Then,
> compiling with -Wcast-qual would have quickly identified all places in
> the code which needed fixes like those Peter has done here. I'm willing
> to change things over to this style if that seems like a useful step
> towards eliminating this particular class of coding issues?
If need be, I am willing to revert the patch that moved Wcast-qual to
the "commented out" section.

|# These are currently disabled because they are noisy.  They will be enabled
# in the future once the codebase is sufficiently modernized to silence
# them.  For now, I don't want them to drown out the other warnings.
# XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wlogical-op])
# XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wparentheses])
# XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wcast-align])
# XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wcast-qual])|
||
|||Perhaps some of its companions could be re-instated as well, should the xserver code base now be considered fully modernized?
|


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140205/c1c54b28/attachment.html>