Hi, On 02/05/2014 06:18 AM, Peter Hutterer wrote: > Allocated in one place, freed in another. You use unchecked strdup in patch 2 and 3, please use XNFstrdup. Other then that the series looks good, so with the above amended this is: Reviewed-by: Hans de Goede <hdegoede at redhat.com> Regards, Hans