[PATCH v2 04/14] xf86Xinput: Modify API for server-managed fd support

[Hans de Goede]

Hi,

On 02/04/2014 02:12 PM, Mark Kettenis wrote:
>> Date: Tue, 04 Feb 2014 13:16:21 +0100
>> From: Hans de Goede <hdegoede at redhat.com>
>>
>> The systemd-logind API uses separate major and minor numbers rather
>> then a dev_t.
> 
> I don't think the design of the Xorg driver API should be blindly
> copied from Linux-specific APIs.
> 
> The integration of systemd support in Xorg gives me an uneasy feeling.
> For us OpenBSD developers systemd is an example of the sort of
> complexity that we think is responsible for many of the security
> issues in software.  I would feel much more at ease if it would be
> firmly jailed in hw/xfree86/os-support/linux.
> 
>> Also I don't want to leak the platform specific dev_t type into
>> public headers.
> 
> That is a valid point; having to include <sys/stat.h> everywhere would
> probably be a bad idea.
> 
> Not quite convinced why you need to add major and minor to the Xorg
> driver API though.  Since you have the file descriptor, you can easily
> call stat(2) to find out.

We're getting the file-descriptor from logind on both init and vtenter,
in order to get if from logind we need to pass it a major + minor, note
that at this point we don't have a fd yet, so nothing to fstat.

Regards,

Hans