[PATCH 1/4] modesetting: Allocate and destroy shadow_fb in drmmode_display

Keith Packard keithp at keithp.com
Thu Dec 25 13:43:56 PST 2014


Jason Ekstrand <jason at jlekstrand.net> writes:

> This way all of the buffer allocation/destruction is in the same file.

>  void
> -drmmode_free_bos(ScrnInfoPtr pScrn, drmmode_ptr drmmode)
> +drmmode_free_bos(ScreenPtr pScreen, drmmode_ptr drmmode)

I'd leave the parameters alone to keep them symmetrical with
drmmode_create_initial_bos and fetch the Screen from the ScrnInfo with
xf86ScrnToScreen.

Otherwise, this patch is

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20141225/97411f39/attachment.sig>


More information about the xorg-devel mailing list