[PATCH 00/12] DMX warning cleanup

Keith Packard keithp at keithp.com
Fri Dec 19 18:20:51 PST 2014


Alan Coopersmith <alan.coopersmith at oracle.com> writes:

> This doesn't get rid of all the warnings in dmx, but it reduces the number
> reported when building with gcc 4.8.2 on Solaris from 222 to 58.
>
> Alan Coopersmith (12):
>   dmx: Add _X_ATTRIBUTE_PRINTF to dmxConfigLog() & dmxConfigOutput()
>   dmx: move format strings inline so gcc can check
>   dmx: fix printf format argument warnings
>   dmx: remove unused variables
>   dmx: attempt to untangle nested loops using same index variable
>   dmx: more unshadowing of variables
>   dmx: glxproxy prototype cleanup
>   dmx: remove redundant declaration of dmxFontPrivateIndex from
>     dmxfont.h
>   dmx: remove redundant redeclarations of variables from other headers
>   dmx: Mark glxIsExtensionSupported as a const char *
>   dmx: constify GCOps & GCFuncs pointers
>   dmx: include header for DMXExtensionInit() in dmx.c

Yeah, RĂ©mi is right, i/j/k are terrible index variable names, but I've
also read through all of these and they look good to me.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20141219/cdb1bf4d/attachment.sig>


More information about the xorg-devel mailing list