[PATCH] modesetting: Enable Xv when using glamor

Alexander E. Patrakov patrakov at gmail.com
Mon Dec 15 07:38:14 PST 2014


14.12.2014 11:29, Keith Packard wrote:
> This just calls the existing function to create the relevant Xv
> adaptor and hook it up.

With that, could anyone please write (preferably in the form of a blog 
post) a feature comparison of the existing card-specific drivers with 
the modesetting driver?

I.e., why should I use nouveau when modesetting exists and even provides 
DRI2/3, GL and Xv?

>
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
>   hw/xfree86/drivers/modesetting/driver.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/hw/xfree86/drivers/modesetting/driver.c b/hw/xfree86/drivers/modesetting/driver.c
> index cad9000..d9a2982 100644
> --- a/hw/xfree86/drivers/modesetting/driver.c
> +++ b/hw/xfree86/drivers/modesetting/driver.c
> @@ -1103,6 +1103,19 @@ ScreenInit(ScreenPtr pScreen, int argc, char **argv)
>
>       xf86DPMSInit(pScreen, xf86DPMSSet, 0);
>
> +#ifdef GLAMOR
> +    if (ms->drmmode.glamor) {
> +        XF86VideoAdaptorPtr     glamor_adaptor;
> +
> +        glamor_adaptor = glamor_xv_init(pScreen, 16);
> +        if (glamor_adaptor != NULL)
> +            xf86XVScreenInit(pScreen, &glamor_adaptor, 1);
> +        else
> +            xf86DrvMsg(pScrn->scrnIndex, X_ERROR,
> +                       "Failed to initialize XV support.\n");
> +    }
> +#endif
> +
>       if (serverGeneration == 1)
>           xf86ShowUnusedOptions(pScrn->scrnIndex, pScrn->options);
>
>

-- 
Alexander E. Patrakov


More information about the xorg-devel mailing list