[PATCH v2] modesetting: Use GBM for buffer allocations if Glamor supports it.

Alexander E. Patrakov patrakov at gmail.com
Tue Dec 9 23:47:42 PST 2014


10.12.2014 07:34, Kenneth Graunke wrote:
> +
> +#ifdef GLAMOR_HAS_GBM
> +    struct gbm_device *gbm;
> +#else
> +    void *gbm;
> +#endif
> +

Yeah, I know, bikeshedding, but... apparently we can get rid of this 
#ifdef completely using a forward declaration. Untested:

struct gbm_device;  /* even without GLAMOR_HAS_GBM this is valid code */

typedef struct {
     ...
     struct gbm_device *gbm;
     ...
} whatever;


-- 
Alexander E. Patrakov


More information about the xorg-devel mailing list