[PATCH] Solaris: delete undocumented, unuseful -protect0 flag

Mark Kettenis mark.kettenis at xs4all.nl
Tue Dec 9 11:00:10 PST 2014


> From: Alan Coopersmith <alan.coopersmith at oracle.com>
> Date: Tue,  9 Dec 2014 10:15:08 -0800
> 
> Solaris already makes the page at address 0 inaccessible by default to
> catch NULL pointer bugs, we don't need a double secret undocumented flag
> to try to make our own hacky attempt at it.
> 
> As a bonus, deleting this code removes gcc warning of:
> 
> sun_init.c: In function 'xf86OpenConsole':
> sun_init.c:103:17: warning: declaration of 'fd' shadows a previous local [-Wshadow]
>              int fd = -1;
>                  ^
> sun_init.c:89:9: warning: shadowed declaration is here [-Wshadow]
>      int fd;
>          ^
> 
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

Reviewed-by: Mark Kettenis <kettenis at openbsd.org> in case you need one.

> ---
>  hw/xfree86/os-support/solaris/sun_init.c |   31 ------------------------------
>  1 file changed, 31 deletions(-)
> 


More information about the xorg-devel mailing list