[PULL] GLX fixes for indirect contexts

Jon TURNEY jon.turney at dronecode.org.uk
Fri Dec 5 09:01:10 PST 2014


On 03/12/2014 18:09, Adam Jackson wrote:
> On Tue, 2014-11-11 at 15:23 +0000, Jon TURNEY wrote:
>> On 22/04/2014 04:56, Keith Packard wrote:
>>> Jon TURNEY writes:
>>>
>>>> Fixes for a few problems with GLX and indirect contexts.
>>>>
>>>> I can reproduce [1/3] and [2/3] on X server 1.15.1, mesa 10.1.0 (from Ubuntu
>>>> 14.04), but not on X server 1.14.5 mesa 9.2.1 (from Ubuntu 13.10), so these are
>>>> probably regressions in 1.15 and may be candidates for that branch.
>>>>
>>>> Jon TURNEY (3):
>>>>     Revert "glx: Simplify glXDestroyContext"
>>>>     glx: Flush context which is being made non-current due to drawable
>>>>       going away
>>>>     glx: Fix crash when a client exits without deleting GL contexts
>>>
>>> I'd love to have Adam take a look at these and see if they seem
>>> reasonable enough.
>>
>> Ping?  Any chance these might be considered for 1.17?
>
> 2/3 looks a little ugly; is there a reason FlushContext's logic can't be
> inlined into the caller?

It seems not, so I have inlined that.

> Other than that these all look fine.  With or without fixing the above,
> series is:
>
> Reviewed-by: Adam Jackson <ajax at redhat.com>

Thanks

Keith,

Please consider pulling into master.

The following changes since commit 4b0d0df34f10a88c10cb23dd50087b59f5c4fece:

   Fix overflow of ConnectionOutput->size and ->count (2014-11-30 
11:37:56 -0800)

are available in the git repository at:

   git://people.freedesktop.org/~jturney/xserver indirect-glx-fixes

for you to fetch changes up to bc71081f0e3d8ce3aecf2cb168431dbc9fe6a87b:

   glx: Fix crash when a client exits without deleting GL contexts 
(2014-12-05 16:41:49 +0000)

----------------------------------------------------------------
Jon TURNEY (3):
       Revert "glx: Simplify glXDestroyContext"
       glx: Flush context which is being made non-current due to 
drawable going away
       glx: Fix crash when a client exits without deleting GL contexts

  glx/glxcmds.c | 4 +++-
  glx/glxext.c  | 8 ++++++--
  glx/glxext.h  | 1 -




More information about the xorg-devel mailing list