[PATCH] render: Fix double-free on ARGB cursor error path

Keith Packard keithp at keithp.com
Wed Aug 20 09:48:40 PDT 2014


Adam Jackson <ajax at redhat.com> writes:

> The gotos deleted by this patch are the only way to get to the bail:
> label here.  In neither case do we need to free the cursor bits from the
> caller; AllocARGBCursor will already do that on the failure path,
> likewise AddResource will call the resource delete function on error.

I don't see AllocARGBCursor freeing anything in the failure paths, so I
think we need to free source/mask. We also need to free argbits

However, AddResource does clean things up nicely so there's no need to
free things from that path.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140820/50e669b7/attachment.sig>


More information about the xorg-devel mailing list