[Xcb] [PATCH libX11] xcb_io: Fix Xlib 32-bit request number wrapping bug

[Jan Smout]

Dear Keith,


thought I'd ping you again. Please fix your spam filter!


Regarding this patch:
http://patchwork.freedesktop.org/patch/16753/


my question is very simple: is this patch good enough to be put in a distro
release? Or are there things to be clarified?

I'm trying to get it into the upcoming Mageia 5 release (I assume it will
be released before Xorg releases it's next libX11 version)


I cannot stress enough the seriousness of this bug. An application that
gets killed by a library without any way to recover is not something to be
taken lightly. In a certain sense I got lucky that my app is so heavy on
graphics, so I was able to find a solution rather quickly (as did Jonas
btw).
I suspect most people just see (seemingly) random crashes, shrug and
restart whatever they were running and then blame the application
programmer for writing shitty software. I find that hard to accept...


best regards,
Jan

On 6 August 2014 17:14, Jan Smout <smout.jan at gmail.com> wrote:

> Hello Keith,
>
> my previous mails probably got lost in the noise. Please see my question
> below:
>
>
> On 29 July 2014 18:56, Jan Smout <smout.jan at gmail.com> wrote:
>
>> Hi all,
>>
>> I recently stumbled into an application that crashed because of this:
>> https://bugs.freedesktop.org/show_bug.cgi?id=71338
>>
>> and quickly found the following patch:
>> http://patchwork.freedesktop.org/patch/16753/
>>
>> which seems to work fine (the application used to crash in less than 24
>> hrs. Has been running for 5 days straight with the patch).
>>
>>
>> Now my question: what is the status of this patch? Are there still
>> details to be clarified before it can be put into the main tree?
>>
>>
>> best regards,
>> Jan
>> --
>> Life is complex, it has a real part and an imaginary part.
>>
>
>
>
> --
> Life is complex, it has a real part and an imaginary part.
>



-- 
Life is complex, it has a real part and an imaginary part.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140820/74f2c857/attachment.html>