[PATCH v2 synaptics] Add support for INPUT_PROP_TOPBUTTONPAD

Hans de Goede hdegoede at redhat.com
Tue Apr 29 00:25:37 PDT 2014


On 04/29/2014 04:34 AM, Peter Hutterer wrote:
> From: Hans de Goede <hdegoede at redhat.com>
> Add a HasSecondaryButtons boolean config option which defaults to true for
> devices with the INPUT_PROP_TOPBUTTONPAD and false for all other devices.
> Only parse the SecondarySoftButtonAreas when this option is true, effectively
> disabling the top buttons when it is false. Likewise, only initialize the
> SecondarySoftButtonAreas property if we enable support for it.
> This means that it is now safe to always set a SecondarySoftButtonAreas
> default in 50-synaptics.conf, and that he section which was intended for
> use with future pnp-id matching can be dropped, as that is now all handled
> in the kernel.
> While at also remove the comment about disabling the bottom edge area, as that
> is now done automatically.
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> Changes to v1:
> - change from "TopClickPad" to HasSecondaryButtons. Not ideal either, I'm
>   still open for bettert suggestions.
> - man page additions
> - don't initialize the property if HasSecondaryButtons is off

Thanks, I had fixing this up on my todo, but it seems you've beat me to it.

Reviewed-by: Hans de Goede <hdegoede at redhat.com>



More information about the xorg-devel mailing list