[PATCH] hw/xfree86: Restore API compatibility for cursor loading functions

Keith Packard keithp at keithp.com
Sun Apr 27 21:37:37 PDT 2014

Aaron Plattner <aplattner at nvidia.com> writes:

> Doesn't this break the ABI vs. xorg-server-  I think just 
> moving the new-vs-ABI17 void-returning fields to the end would fix it 
> since xf86CreateCursorInfoRec() uses calloc() to allocate the
> structure.

Yes, it does. I wondered if you wanted me to just bump the ABI number
again to be able to tell that this has changed. As you know, I prefer to
have functions placed logically within the structure to make reading the
definition easier. It's too easy to miss something when functions are
ordered chronologically...

I want to treat the temporary mistake of changing the function return
type as a bug so that existing drivers retain API compatibility with the
new server version. I'm happy to say that with the current fix, my
existing drivers 'just work' again.

If you send in an ABI version bump, I'll merge it in immediately.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140427/a393552c/attachment.sig>

More information about the xorg-devel mailing list