[PATCH 3/3] glamor: Publish change_window_attributes and copy_window

Keith Packard keithp at keithp.com
Fri Apr 25 17:52:54 PDT 2014

Eric Anholt <eric at anholt.net> writes:

> Keith Packard <keithp at keithp.com> writes:
>> Because uxa doesn't just use glamor directly, it keeps these two
>> functions from being wrapped so that they get called
>> automatically. Publishing these will allow uxa to call them directly.
> Instead of making uxa get more complicated, let's just move the hooking
> of these two out of the GLAMOR_USE_SCREEN block (since GLAMOR_USE_SCREEN
> is just the "Everybody but UXA" flag).

Hrm. Uxa is still going to be broken as it wraps on top of glamor, which
means uxa_change_window_attributes will be called, and that will have to
"know" that the underlying function is glamor and prepare access
correctly for that. I'm not sure that's a net win here. Everwhere else,
uxa calls into exported glamor functions; these were just the last two
that it needed to complete the work.

Of course, what we should do soon is just get rid of the glamor paths in
uxa and have the driver just use glamor. But, until we've finished
making glamor fast everywhere, that doesn't seem ideal.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140425/6c4f1b05/attachment.sig>

More information about the xorg-devel mailing list