[PATCH] present: Queue flips for later execution

Keith Packard keithp at keithp.com
Tue Apr 22 15:01:24 PDT 2014

Eric Anholt <eric at anholt.net> writes:

>>              vblank->pixmap = NULL;
>>              vblank->idle_fence = NULL;
>> +            vblank->flip = FALSE;
>> +            if (vblank->flip_ready)
>> +                present_re_execute(vblank);
>>          }
>>      }
> So, when we're replacing a previous flip for a given MSC with a new
> presented pixmap for the same MSC, we disable pageflip for it.  I don't
> see anything else that would reset the flip bit (flip only gets set in
> present_pixmap below).  Shouldn't we be doing a vblank->flip =
> check_flip(...), instead?

This is smashing the state of the vblank which is no longer going to be
executed. The new pending vblank will be flipped as appropriate.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140422/8160bd45/attachment.sig>

More information about the xorg-devel mailing list