[PATCH 09/12] glamor: Replace glamor_get/put_context() with just glamor_make_current().
Adam Jackson
ajax at nwnk.net
Tue Apr 22 14:20:07 PDT 2014
On Fri, 2014-04-18 at 11:40 -0700, Eric Anholt wrote:
> @@ -545,9 +541,8 @@ _glamor_copy_n_to_n(DrawablePtr src,
> fail:
> - glamor_get_context(glamor_priv);
> + glamor_make_current(glamor_priv);
> glamor_set_alu(screen, GXcopy);
> - glamor_put_context(glamor_priv);
>
> if (ok)
> return TRUE;
This made me double-take. I mean, it can't be wrong, but I'm not sure
what it'd protect against; glamor_create_pixmap() can't change to a
proxy GLX context, right? Or are we assuming that the driver could be
using another GL context below glamor itself? That'd be super weird...
- ajax
More information about the xorg-devel
mailing list