[PATCH] glamor: Fix accelerated rendering of GTK's ARGB vs xBGR composites.

Keith Packard keithp at keithp.com
Mon Apr 21 20:53:45 PDT 2014

Eric Anholt <eric at anholt.net> writes:

> There is some complicated code to support tweaking the format as we
> upload from a SHM pixmap (aka the GTK icon cache), but if we weren't
> sourcing from a SHM pixmap we just forgot to check that the formats
> matched at all.
> We could potentially be a little more discerning here (xRGB source and
> ARGB mask would be fine, for example), but this will all change with
> texture views anyway, so just get the rendering working for 1.16
> release.
> Fixes the new rendercheck gtk_argb_xbgr test.
> v2: Squash in keithp's fix for checking that we have a non-NULL
>     pixmap, and reword the comment even more.

Reviewed-by: Keith Packard <keithp at keithp.com>

(please send along a Signed-off-by: line and I'll merge this in)
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140421/aedd715c/attachment.sig>

More information about the xorg-devel mailing list