[PATCH xf86-input-synaptics] Fix product ID cutoff for MODEL_APPLETOUCH/MODEL_UNIBODY_MACBOOK

Peter Hutterer peter.hutterer at who-t.net
Mon Apr 21 18:30:13 PDT 2014


On Sat, Apr 19, 2014 at 10:23:00PM -0500, Clinton Sprain wrote:
> A handful of Macbooks are being tagged as MODEL_UNIBODY_MACBOOKs when they
> should not be. This causes the default sensitivity to be very low for them,
> making the touchpad very difficult to use. This change moves the product ID
> cutoff so those devices fall into the old bucket again.

just to confirm: which one of those do you have or did you see the bug
reported on? Looking at the kernel's ID collection this change only affects
first-gen macbook airs and should've been an issue for roughly two years
already.

Which again makes me wonder: what change exposed this bug recently? 

Cheers,
   Peter

>  src/eventcomm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/eventcomm.c b/src/eventcomm.c
> index 858efeb..405eeb9 100644
> --- a/src/eventcomm.c
> +++ b/src/eventcomm.c
> @@ -305,8 +305,8 @@ struct model_lookup_t {
>  static struct model_lookup_t model_lookup_table[] = {
>      {0x0002, 0x0007, 0x0007, MODEL_SYNAPTICS},
>      {0x0002, 0x0008, 0x0008, MODEL_ALPS},
> -    {0x05ac, PRODUCT_ANY, 0x222, MODEL_APPLETOUCH},
> -    {0x05ac, 0x223, PRODUCT_ANY, MODEL_UNIBODY_MACBOOK},
> +    {0x05ac, PRODUCT_ANY, 0x22f, MODEL_APPLETOUCH},
> +    {0x05ac, 0x230, PRODUCT_ANY, MODEL_UNIBODY_MACBOOK},
>      {0x0002, 0x000e, 0x000e, MODEL_ELANTECH},
>      {0x0, 0x0, 0x0, 0x0}
>  };
> -- 
> 1.9.1


More information about the xorg-devel mailing list