[PATCH libXfont] Fix buffer read overrun

Jasper St. Pierre jstpierre at mecheye.net
Mon Apr 21 18:14:26 PDT 2014


Always using strlen(s); should be fine. The compiler will optimize it out
for a literal string anyway.


On Fri, Apr 18, 2014 at 4:39 PM, Keith Packard <keithp at keithp.com> wrote:

> Alan Coopersmith <alan.coopersmith at oracle.com> writes:
>
> > They work, as long as you only ever pass a literal string to them, not a
> > pointer.
>
> Right, but there's no type safety in that.
>
> > Seems like a reasonable simplification in the server - hard to use from
> other
> > modules (libXfont, drivers, etc.) until you're sure you'll only ever be
> used
> > with a server recognizing that.
>
> So, presumably a macro in some convenient header file would still be
> useful for external consumers.
>
> --
> keith.packard at intel.com
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>



-- 
  Jasper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140421/31c04844/attachment.html>


More information about the xorg-devel mailing list