[PATCH] glamor: Fix accelerated rendering of GTK's ARGB vs xBGR composites.

[Keith Packard]

Eric Anholt <eric at anholt.net> writes:

> +    /* If the formats don't match, and the pixmap was already uploaded
> +     * (so the dynamic code above doesn't apply), then fall back to
> +     * software.  We should use texture views to fix this properly.
> +     */
> +    if (source_pixmap == mask_pixmap && source->format != mask->format)
> +        goto fail;

source_pixmap is NULL for solid sources. mask_pixmap is NULL for solid
masks or when mask is NULL. In the latter case, this crashes...

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Only-perform-the-mask-comparison-when-both-mask-and-.patch
Type: text/x-diff
Size: 1104 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140421/bfa22d9a/attachment-0001.patch>
-------------- next part --------------

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140421/bfa22d9a/attachment-0001.sig>