bug in glamor on ShmPutImage for XY images

[Eric Anholt]

Jamey Sharp <jamey at minilop.net> writes:

> I haven't understood enough of the implementation to see how to fix
> this, but I can reliably crash Xephyr this way:
>
> hw/kdrive/ephyr/Xephyr :1 -screen 1024x768 -glamor
> DISPLAY=:1 x11perf -shmputxy10
>
> Without the -glamor option to Xephyr, the x11perf command runs
> successfully. I'm testing on current git master.
>
> As far as I can tell, fbPutXYImage is getting called with a pDrawable
> for which the pixmap's devPrivate.ptr is NULL. It's setting FbBits
> *dst to that NULL and passing it down to fbBltOne, which then
> segfaults.

I ran into this segfault yesterday, and decided to just pull keithp's
rewrite of get/putimage: It's massively faster, and it also fixes this
bug.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140421/9f0a7201/attachment.sig>