[PATCH 1/3] randr: Fix crash for NULL swap dispatch procs

walter harms wharms at bfs.de
Sun Apr 20 11:54:23 PDT 2014



Am 19.04.2014 03:29, schrieb Robert Morell:
> The previous code was checking the wrong table for function pointers.
> 
> Signed-off-by: Robert Morell <rmorell at nvidia.com>
> ---
>  randr/randr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/randr/randr.c b/randr/randr.c
> index 3c97714d8e1d..6e3f14b4e704 100644
> --- a/randr/randr.c
> +++ b/randr/randr.c
> @@ -679,7 +679,7 @@ static int
>  SProcRRDispatch(ClientPtr client)
>  {
>      REQUEST(xReq);
> -    if (stuff->data >= RRNumberRequests || !ProcRandrVector[stuff->data])
> +    if (stuff->data >= RRNumberRequests || !SProcRandrVector[stuff->data])
>          return BadRequest;
>      return (*SProcRandrVector[stuff->data]) (client);
>  }

hi,
did you try that ? i am not sure about !SProcRandrVector[stuff->data]. can it really happen
that certain elements of that array do not exists ?

re,
 wh


More information about the xorg-devel mailing list