[PATCH 2/2] DRI2SwapBuffers: Fix uninitialized target SBC.

Keith Packard keithp at keithp.com
Fri Apr 18 16:45:27 PDT 2014

Jamey Sharp <jamey at minilop.net> writes:

> Fixes Piglit test "swapbuffersmsc-return swap_interval 0".
> Ensure that *swap_target gets initialized on any 'return Success' path,
> even if the swap request can't be completed by the driver and the server
> falls back to a simple blit. That path can also be triggered by setting
> swap_interval to 0, which disables sync to vertical retrace.
> We originally found this bug because for some reason SDL2 automatically
> sets swap_interval to 0, when we were trying to test OML_sync_control in
> an SDL2 test application. We then discovered that the above-mentioned
> Piglit test has been failing for the same reason since it was
> introduced.

Reviewed-by: Keith Packard <keithp at keithp.com>

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140418/2fa18ae9/attachment.sig>

More information about the xorg-devel mailing list