[PATCH xinit] startx: Pass vtX as long as the user did not specify one

Hans de Goede hdegoede at redhat.com
Mon Apr 7 06:15:20 PDT 2014


Hi,

On 04/07/2014 03:05 PM, Gaetan Nadon wrote:
> On 14-04-07 07:42 AM, James Cloos wrote:
>> But re commit 44915d6953076, 
>>
>> HG>          tty_num=$(echo "$tty" | grep -oE '[0-9]+$')
>>
>> Is grep -o available everwhere startx(1) runs?
>>
>> The posix page, grep.1p, does not mention -o.
>>
>> It looks like each of the BSDs have adopted it, but only midstream
>> (eg, its documented in OpenBSD 5.0, but not in 4.9).
> I looked in the autoconf manual:
> 
>     http://www.gnu.org/software/autoconf/manual/autoconf.html#grep
> 
>     "Portable scripts can rely on the grepoptions -c, -l, -n, and -v,
>     but should avoid other options"

This grep is in a #ifdef __linux__ block, so it should be fine.

Regards,

Hans



More information about the xorg-devel mailing list