[PATCH xf86-video-nouveau 2/2] Add support for server managed fds

[Martin Peres]

On 20/03/2014 09:43, Hans de Goede wrote:
> Hi,
>
> On 03/20/2014 01:23 AM, Martin Peres wrote:
>> On 17/03/2014 17:37, Hans de Goede wrote:
>>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> Hi Hans,
>>
>> When compiling these patches, it generated some warnings because "NVEntPtr pNVEnt" was not defined in NVEnterVT and NVLeaveVT. I have tested the patches on top of xf86-video-nouveau-git and latest-released x-server with no apparent regression. I'm trying to set up the rest of the xserver-git environment to be able to check how it will work with the next x-server, with and without logind. I'll need to get up to speed with logind too.
> Thanks, the fix looks good, feel free to squash it into the original
> patch introducing the warnings.
>
>> Anyway, thanks for your work, I'm looking forward to using it :)
> You're welcome, thanks for testing! So if you want to test things
> with Xorg not running as root, you need a recent systemd, ie
> 208 as found in Fedora-20 will do. And then build the xserver +
> drivers you need from git, and use startx from a text vc, that is all.
>
> Note that many display managers won't start Xorg inside a user login
> session, and then systemd-logind will refuse to talk to Xorg. So
> if you start Xorg under say gdm you will get a single line
> about systemd-logind in your Xorg.0.log saying that it failed
> to take control of the session, and then from there on you're
> running the non server-fd code-paths :)
>
> Regards,
>
> Hans

Hi Hans,

I'm very sorry that it took so long for me to test your patches.

I didn't test the logind case because I thought it was a good idea to
build the xserver in a chroot... which doesn't seem to be easily
compatible with logind.

Anyway, I checked there would be no regressions in the no-logind
case (current and next x-server) and everything seems in order
hence why I pushed both patches (not sure when I'll have the motivation
to go through installing all those repos from git again)!

Here the patches are: 
http://cgit.freedesktop.org/nouveau/xf86-video-nouveau/

Ben thinks he'll make a release in a week or two. Hopefully, it will 
land in rawhide
and people can start testing the logind case for me (/me feels *shameful*).

Regards,
Martin