[PATCH xinit v3 3/3] startx: Under Linux start X on the current VT

[Connor Behan]

On 04/04/14 05:39 AM, Peter Hutterer wrote:
> On Mon, Mar 31, 2014 at 03:51:46PM +0200, Hans de Goede wrote:
>> When we let X allocate a new VT, systemd-logind will not recognize any
>> processes running on this VT as belonging to a valid session (since there
>> was no pam session opened on that tty).
>>
>> This causes problems like PolicyKit denials for these processes.
>>
>> ConsoleKit under Linux has been deprecated for a few years now and is no
>> longer being maintained, so simply make this the default under Linux.
>>
>> Note we do not pass in the vt if the user has specified an alternative server
>> to start, as the vtX argument is only valid for the Xorg server, likewise we
>> omit it if the user has specified any other server arguments.
>>
>> Fixes:
>> https://bugzilla.redhat.com/show_bug.cgi?id=806491
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
So this would cause an unrelated option like -nolisten tcp to change the
VT on which X runs? I think this violates the principle of least surprise.

I would prefer a patch that checks if X is setuid root. If so, use VT7
because that's what everyone is used to. If not, use the current VT.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 555 bytes
Desc: OpenPGP digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140404/1adb5e3d/attachment.sig>