[PATCH 04/16] glamor: Replace fallback preparation code

Keith Packard keithp at keithp.com
Wed Apr 2 16:06:06 PDT 2014


Eric Anholt <eric at anholt.net> writes:

> GLES2 only allows WRITE_ONLY in the glMapBuffer interface (and only when
> GL_OES_mapbuffer is available), which the old path avoided.  I think
> your change just totally breaks fallbacks in gles2.

So, in GLES2 mode, we just need to malloc memory and download to
that. That's an easy change to make.

> I noticed this when going to delete the code you made dead by this
> patch.

GLES is crippled beyond belief. Here's a different version of the
prepare patch which doesn't use PBOs.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-glamor-Replace-fallback-preparation-code.patch
Type: text/x-diff
Size: 23355 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140402/782971d5/attachment.patch>
-------------- next part --------------

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140402/782971d5/attachment.sig>


More information about the xorg-devel mailing list