[PATCH 3/8] glamor: Stop calling eglMakeCurrent (.., EGL_NO_SURFACE)

Eric Anholt eric at anholt.net
Wed Apr 2 11:46:59 PDT 2014


Keith Packard <keithp at keithp.com> writes:

> This eliminates a huge cost when using EGL.
>
> Signed-off-by: Keith Packard <keithp at keithp.com>

It also, as far as I've heard, causes segfaults when you use indirect
GLX.  I never quite got my patchset for global GL context management
finished (I think I know what the remaining bug was now), but we
probably shouldn't land this until that's done.

> ---
>  glamor/glamor_egl.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c
> index 8123421..0248efa 100644
> --- a/glamor/glamor_egl.c
> +++ b/glamor/glamor_egl.c
> @@ -116,9 +116,6 @@ glamor_egl_put_context(struct glamor_context *glamor_ctx)
>  {
>      if (--glamor_ctx->get_count)
>          return;
> -
> -    eglMakeCurrent(glamor_ctx->display, EGL_NO_SURFACE,
> -                   EGL_NO_SURFACE, EGL_NO_CONTEXT);
>  }
>  
>  static EGLImageKHR
> -- 
> 1.9.0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140402/b9372188/attachment-0001.sig>


More information about the xorg-devel mailing list