[PATCH 2/8] glamor: the render Composite hook must call SourceValidate

[Eric Anholt]

Keith Packard <keithp at keithp.com> writes:

> This call is required for correct operation of the Render extension,
> in particular it is necessary for software cursors and Composite to
> work correctly.
>
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
>  glamor/glamor_render.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/glamor/glamor_render.c b/glamor/glamor_render.c
> index cdf8eff..ae6f769 100644
> --- a/glamor/glamor_render.c
> +++ b/glamor/glamor_render.c
> @@ -1597,6 +1597,10 @@ _glamor_composite(CARD8 op,
>      DrawablePtr saved_mask_drawable;
>      int force_clip = 0;
>  
> +    miCompositeSourceValidate(source);
> +    if (mask)
> +        miCompositeSourceValidate(mask);
> +

These two calls are also done by miComputeCompositeRegion, which is
called very soon after this -- did you observe an actual bug that was
fixed by this patch?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140402/97c86ce3/attachment.sig>