[PATCH libXt] Use $(MKDIR_P) in Makefile.am for better code portability

Alan Coopersmith alan.coopersmith at oracle.com
Sat Sep 21 10:48:48 PDT 2013


On 09/21/13 09:58 AM, Gaetan Nadon wrote:
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>   src/Makefile.am |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index a466ae5..8c1a664 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -98,8 +98,8 @@ $(BUILT_HEADER): $(BUILT_SOURCE)
>
>   $(BUILT_SOURCE):
>   	$(AM_V_GEN)$(top_builddir)/util/makestrs -i $(top_srcdir) $(STRINGSABIOPTIONS) < $(STRING_LIST) > StringDefs.c
> -	$(AM_V_at)mkdir -p $(top_builddir)/src
> -	$(AM_V_at)mkdir -p $(top_builddir)/include/X11
> +	$(AM_V_at)$(MKDIR_P) $(top_builddir)/src
> +	$(AM_V_at)$(MKDIR_P) $(top_builddir)/include/X11
>   	$(AM_V_at)cp StringDefs.h $(top_builddir)/include/X11
>   	$(AM_V_at)cp Shell.h $(top_builddir)/include/X11
>   	$(AM_V_at)rm StringDefs.h Shell.h
>

Do we need to add AC_PROG_MKDIR_P to configure.ac or xorg-macros, or does
automake automatically call it already?

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list