[PATCHES] fix build on GNU/Hurd with GCC 4.8

[Chris Clayton]

On 09/18/13 13:29, Chris Clayton wrote:
> Hi Matt,
>
> On 09/18/13 05:50, Matt Dew wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Chris,
>>    I'm guessing this won't affect you but can you verify that?  I don't
>> want a nasty loop where fixing one things breaks another.
>
>  From the names of the directory that contains the files affected by the
> inclusion of hurd.h, I can't imagine how that patch would affect a build
> on linux. Still, a 32-year career in IT taught me to expect the
> unexpected, so I cloned the 1.14 branch, applied that patch (by hand -
> it's been mangled by someone's mailer) and did a simple autogen.sh /
> configure / make. As expected, the build completed successfully.
>
> The other patch, which Pino said affected other unix systems, is not
> included in the mail that arrived here, so, obviously, I haven't built
> with that applied.

Why I didn't do this simple thing yesterday, I can't explain! I got this 
"missing" patch from the xorg-devel mail archive and applied it to the 
1.14 branch. A build finished finished successfully, so from here, the 
patches look good.

Chris

>
> Cheers,
> Chris
>
>>
>> thanks,
>> Matt
>>
>> On 09/17/2013 12:02 PM, Samuel Thibault wrote:
>>> Hello,
>>>
>>> Pino Toscano, le Wed 28 Aug 2013 17:36:26 +0200, a écrit :
>>>> with GCC 4.8, few "implicit declaration of function" warnings
>>>> become errors, breaking the build of xserver on the Hurd.
>>>>
>>>> Attached there are two patches, which apply fine in both master
>>>> and server-1.14-branch branches, which fix the errors providing
>>>> the right includes: * the inclusion of <hurd.h> in Hurd parts
>>>> should be straightforward * the move of the <arpa/inet.h> (which
>>>> is POSIX) to a move general location affects any other Unix
>>>> system with IPv6 support, I hope it is not a problem for all the
>>>> supported platforms
>>>
>>> Acked-by: Samuel Thibault <samuel.thibault at ens-lyon.org>
>>>
>>> Could somebody push that to the server?  We really need it.
>>>
>>> Thanks, Samuel
>>>
>>>  From ef6a236cf9b795017c9c8c4447a6735fa04bb061 Mon Sep 17 00:00:00
>>> 2001 From: Pino Toscano <toscano.pino at tiscali.it> Date: Wed, 28 Aug
>>> 2013 17:04:48 +0200 Subject: [PATCH] xfree86/hurd: include
>>> <hurd.h>
>>>
>>> Needed for using get_privileged_port.
>>>
>>> Signed-off-by: Pino Toscano <toscano.pino at tiscali.it> ---
>>> hw/xfree86/os-support/hurd/hurd_init.c  |    1 +
>>> hw/xfree86/os-support/hurd/hurd_mmap.c  |    1 +
>>> hw/xfree86/os-support/hurd/hurd_video.c |    1 + 3 files changed, 3
>>> insertions(+)
>>>
>>> diff --git a/hw/xfree86/os-support/hurd/hurd_init.c
>>> b/hw/xfree86/os-support/hurd/hurd_init.c index 185b2b9..fe1a764
>>> 100644 --- a/hw/xfree86/os-support/hurd/hurd_init.c +++
>>> b/hw/xfree86/os-support/hurd/hurd_init.c @@ -42,6 +42,7 @@ #include
>>> <sys/file.h> #include <assert.h> #include <mach.h> +#include
>>> <hurd.h>
>>>
>>> int xf86ProcessArgument(int argc, char **argv, int i) diff --git
>>> a/hw/xfree86/os-support/hurd/hurd_mmap.c
>>> b/hw/xfree86/os-support/hurd/hurd_mmap.c index 6ac9efd..8e089ca
>>> 100644 --- a/hw/xfree86/os-support/hurd/hurd_mmap.c +++
>>> b/hw/xfree86/os-support/hurd/hurd_mmap.c @@ -27,6 +27,7 @@
>>> #include<mach.h> #include<device/device.h>
>>> #include<mach/machine/mach_i386.h> +#include <hurd.h>
>>>
>>> #include <X11/X.h>
>>>
>>> diff --git a/hw/xfree86/os-support/hurd/hurd_video.c
>>> b/hw/xfree86/os-support/hurd/hurd_video.c index 72474ba..b3b94c9
>>> 100644 --- a/hw/xfree86/os-support/hurd/hurd_video.c +++
>>> b/hw/xfree86/os-support/hurd/hurd_video.c @@ -28,6 +28,7 @@
>>> #include <mach.h> #include <device/device.h> #include
>>> <mach/machine/mach_i386.h> +#include <hurd.h>
>>>
>>> #include <X11/X.h> #include "input.h"
>>>
>>
>>
>> - --
>> Matt Dew                            Key signature: 0xF7C3 BEC3
>> Fingerprint: FDB1 9D94 C573 DC29 BCCB 2F9F A6BF 3771 F7C3 BEC3
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.13 (GNU/Linux)
>> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>>
>> iQEcBAEBAgAGBQJSOTEiAAoJEKa/N3H3w77DR+0H/jW12BBCYgGK2Oy25zHj6wvZ
>> y3xKi4PK+Pyb2ad1p/hTnbmD9usl/8+tSOmOZRU7i1OgjfP7vj012aCMyr2ZMmt2
>> +Sd0s2dpYxoobRg/m51+IFs2PiOVfCUH6NLkkrOP6xTQny57YG207fQYED3fJWwu
>> mFHT2CcrdjEBxd5gDc+2jxtGCz9656qTGHLTN73TKdnhGvT56Z8cIwq2VnBntiuX
>> V6SyQe6OZziIWsZ0POKyjiIeMFBjzMIn5fwufW3FzV4L48leJPOppsSx14YSxLd1
>> oH3n9xAlllfnC8AugtiJRzyVPvhFr8zbXe3iC3yoiBXc79x1RaGzHXiMLaa+vNU=
>> =zA5L
>> -----END PGP SIGNATURE-----
>>