[REPOST PATCH xauth] Don't crash when running past the end of the chain

[Egbert Eich]

Hi Tilman,

On Wed, Sep 18, 2013 at 10:28:14PM +0200, Dr. Tilmann Bubeck wrote:
> Hi Egbert,
> 
> I developed a patch for xauth to fix some nasty problems. I first asked Alan
> to apply the patch but he had not enough time to do it. So after some time
> he gave me access to Xorg as a commiter (I certainly did not do this on my
> own).
> 
> So my plan was to look after xauth, which I still want to do. However, I
> changed my employer in the mean time so I currently have not much spare
> time. But this will change soon, as I am now more incorporated to my new
> job.
> 
> I now promise to apply the patch and all other pending stuff until the end
> of the month. If I fail, then feel free to remove me from the MAINTAINERs
> file and revoke my access rights. However, I am confident, that I can do it,
> because it really is not much to do.


I finally found your patches in bugzilla - you made a fix for exactly one
of the problems I also addressed ie:

   [PATCH xauth] Make matching algorithm mimic XauGet*AuthByAddr

Your approach is similar however there is a difference and I'm currently trying 
to find out which way is the correct one. I had some reason why I chose my way
but since it was quite some time ago I don't exactly recall why.
Thus I'm looking into this ATM.

Regarding committing the patches I can commit patches myself - I just don't
want to step over the maintainer. I would suggest that I commit

   [PATCH xauth] Don't crash when running past the end of the chain 

as this fixes a segfault and should be pretty straight forward.
I would suggest that you have a look at at

   [PATCH xauth] Look for FamilyLocal if inet or inet6 address is loopback

as it is always good to have a second look - if I didn't do anything 
stupid. I will bounce the 3 messages to you in case you don't have them
any more.

Good night! 

Cheers,
	Egbert.


> 
> Feel free to contact me for further questions.
> 
> Kind regards,
>  Tilmann
> 
> Am 18.09.2013 19:44, schrieb Egbert Eich:
> >
> >Hi!
> >
> >On August 14 I've reposted three patches for xauth to this mailing list.
> >I did so, because I had discovered that a 'Dr. Tilmann Bubeck' has added
> >himself as maintainer of the xauth package to the xorg/doc/xorg-docs/MAINTAINERS
> >file on Jan. 22 2013 - considering the change frequency of this file this
> >is not that long ago.
> >The only reply I ever got on any of the 3 posts was by Walter Harms.
> >
> >So I did a quick check in the xauth package which did not turn up any
> >contribution by this individual.
> >
> >After doing further investigations I concluded that this commit apparently
> >was the only thing that he has ever contributed to any X.Org related package.
> >
> >Research on Google did not turn up any relevant affiliation to any X.Org
> >related software.
> >
> >For this change his name and email address is listed not only for the author
> >but also for the committer.
> >
> >This begs the question how did this commit ever get into the xorg-docs
> >package?
> >Did he commit this change himself - and if so, how did he get commit
> >access to the X.Org repos?
> >Or if he didn't do it himself (and he may not even be aware of this commit),
> >who else did - using his name and email?
> >
> >Cheers,
> >	Egbert.
> >
> 
> -- 
> Mit freundlichen Gruessen,
>   Tilmann Bubeck
> 
> 
> //// dr. tilmann bubeck, it professional & geek
> ////
> //// till at bubecks.de       /  http://www.bubecks.de
> //// mobile: 0172-8842972  /  fon: 0711-7227719     /  fax: 0711-7227734
> //// widmaierstr. 58       /  70567 stuttgart       /  germany