[libX11/nls] requesting patch review: composing breve via lowercase u

Benno Schulenberg bensberg at justemail.net
Mon Sep 16 05:40:24 PDT 2013


On Sun, Aug 11, 2013, at 10:18, Benno Schulenberg wrote:
> The Compose tables currently allow to put a breve on a letter via
> the capital U (for example: <Multi_key> <U> <a> produces ă).  This
> is fine for putting a breve on an uppercase letter, where one has
> to press <Shift> anyway, but it is awkward to have to press <Shift>
> when wanting to add a breve to a lowercase letter.

So, does anyone have any objections against the following sequences
with lowercase <u> being added?:

    <Multi_key> <u> <A>              	: "Ă"   U0102 # LATIN CAPITAL LETTER A WITH BREVE
    <Multi_key> <u> <a>              	: "ă"   U0103 # LATIN SMALL LETTER A WITH BREVE
    <Multi_key> <u> <E>              	: "Ĕ"   U0114 # LATIN CAPITAL LETTER E WITH BREVE
    <Multi_key> <u> <e>              	: "ĕ"   U0115 # LATIN SMALL LETTER E WITH BREVE
    <Multi_key> <u> <G>              	: "Ğ"   U011E # LATIN CAPITAL LETTER G WITH BREVE
    <Multi_key> <u> <g>              	: "ğ"   U011F # LATIN SMALL LETTER G WITH BREVE
    <Multi_key> <u> <I>              	: "Ĭ"   U012C # LATIN CAPITAL LETTER I WITH BREVE
    <Multi_key> <u> <i>              	: "ĭ"   U012D # LATIN SMALL LETTER I WITH BREVE
    <Multi_key> <u> <O>              	: "Ŏ"   U014E # LATIN CAPITAL LETTER O WITH BREVE
    <Multi_key> <u> <o>              	: "ŏ"   U014F # LATIN SMALL LETTER O WITH BREVE
    <Multi_key> <u> <U>              	: "Ŭ"   U016C # LATIN CAPITAL LETTER U WITH BREVE


For the original submission see:
>     https://bugs.freedesktop.org/show_bug.cgi?id=59319
> 
> [Please CC, not subscribed.]


The patches in full:

> From 70f398690b457ee0900741508ab71f9f3efd5744 Mon Sep 17 00:00:00 2001
> From: Benno Schulenberg <bensberg at justemail.net>
> Date: Fri, 11 Jan 2013 23:08:12 +0100
> Subject: [PATCH 2/3] Compose: Allow letters with breve to be composed via initial lowercase u.
> 
> Signed-off-by: Benno Schulenberg <bensberg at justemail.net>
> ---
>  nls/en_US.UTF-8/Compose.pre |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/nls/en_US.UTF-8/Compose.pre b/nls/en_US.UTF-8/Compose.pre
> index 2ee73d6..e6b5d24 100644
> --- a/nls/en_US.UTF-8/Compose.pre
> +++ b/nls/en_US.UTF-8/Compose.pre
> @@ -812,10 +812,12 @@ XCOMM Part 3
>  <Multi_key> <a> <minus>          	: "ā"   U0100 # LATIN CAPITAL LETTER A WITH MACRON
>  <dead_breve> <A>                 	: "Ă"   U0102 # LATIN CAPITAL LETTER A WITH BREVE
>  <Multi_key> <U> <A>              	: "Ă"   U0102 # LATIN CAPITAL LETTER A WITH BREVE
> +<Multi_key> <u> <A>              	: "Ă"   U0102 # LATIN CAPITAL LETTER A WITH BREVE
>  <Multi_key> <b> <A>              	: "Ă"   U0102 # LATIN CAPITAL LETTER A WITH BREVE
>  <Multi_key> <A> <parenleft> 		: "Ă"   U0102 # LATIN CAPITAL LETTER A WITH BREVE
>  <dead_breve> <a>                 	: "ă"   U0103 # LATIN SMALL LETTER A WITH BREVE
>  <Multi_key> <U> <a>              	: "ă"   U0103 # LATIN SMALL LETTER A WITH BREVE
> +<Multi_key> <u> <a>              	: "ă"   U0103 # LATIN SMALL LETTER A WITH BREVE
>  <Multi_key> <b> <a>              	: "ă"   U0103 # LATIN SMALL LETTER A WITH BREVE
>  <Multi_key> <a> <parenleft> 		: "ă"   U0103 # LATIN SMALL LETTER A WITH BREVE
>  <dead_ogonek> <A>                	: "Ą"   U0104 # LATIN CAPITAL LETTER A WITH OGONEK
> @@ -882,9 +884,11 @@ XCOMM Part 3
>  <Multi_key> <e> <minus> 		: "ē"   U0113 # LATIN SMALL LETTER E WITH MACRON
>  <dead_breve> <E>                 	: "Ĕ"   U0114 # LATIN CAPITAL LETTER E WITH BREVE
>  <Multi_key> <U> <E>              	: "Ĕ"   U0114 # LATIN CAPITAL LETTER E WITH BREVE
> +<Multi_key> <u> <E>              	: "Ĕ"   U0114 # LATIN CAPITAL LETTER E WITH BREVE
>  <Multi_key> <b> <E>              	: "Ĕ"   U0114 # LATIN CAPITAL LETTER E WITH BREVE
>  <dead_breve> <e>                 	: "ĕ"   U0115 # LATIN SMALL LETTER E WITH BREVE
>  <Multi_key> <U> <e>              	: "ĕ"   U0115 # LATIN SMALL LETTER E WITH BREVE
> +<Multi_key> <u> <e>              	: "ĕ"   U0115 # LATIN SMALL LETTER E WITH BREVE
>  <Multi_key> <b> <e>              	: "ĕ"   U0115 # LATIN SMALL LETTER E WITH BREVE
>  <dead_abovedot> <E>              	: "Ė"   U0116 # LATIN CAPITAL LETTER E WITH DOT ABOVE
>  <Multi_key> <period> <E>         	: "Ė"   U0116 # LATIN CAPITAL LETTER E WITH DOT ABOVE
> @@ -914,6 +918,7 @@ XCOMM Part 3
>  <Multi_key> <asciicircum> <g>    	: "ĝ"   U011D # LATIN SMALL LETTER G WITH CIRCUMFLEX
>  <dead_breve> <G>                 	: "Ğ"   U011E # LATIN CAPITAL LETTER G WITH BREVE
>  <Multi_key> <U> <G>              	: "Ğ"   U011E # LATIN CAPITAL LETTER G WITH BREVE
> +<Multi_key> <u> <G>              	: "Ğ"   U011E # LATIN CAPITAL LETTER G WITH BREVE
>  <Multi_key> <G> <U> 			: "Ğ"   U011E # LATIN CAPITAL LETTER G WITH BREVE
>  <Multi_key> <b> <G>              	: "Ğ"   U011E # LATIN CAPITAL LETTER G WITH BREVE
>  <Multi_key> <breve> <G> 		: "Ğ"   U011E # LATIN CAPITAL LETTER G WITH BREVE
> @@ -921,6 +926,7 @@ XCOMM Part 3
>  <Multi_key> <G> <parenleft> 		: "Ğ"   U011E # LATIN CAPITAL LETTER G WITH BREVE
>  <dead_breve> <g>                 	: "ğ"   U011F # LATIN SMALL LETTER G WITH BREVE
>  <Multi_key> <U> <g>              	: "ğ"   U011F # LATIN SMALL LETTER G WITH BREVE
> +<Multi_key> <u> <g>              	: "ğ"   U011F # LATIN SMALL LETTER G WITH BREVE
>  <Multi_key> <g> <U> 			: "ğ"   U011F # LATIN SMALL LETTER G WITH BREVE
>  <Multi_key> <b> <g>              	: "ğ"   U011F # LATIN SMALL LETTER G WITH BREVE
>  <Multi_key> <breve> <g> 		: "ğ"   U011F # LATIN SMALL LETTER G WITH BREVE
> @@ -970,9 +976,11 @@ XCOMM Part 3
>  <Multi_key> <i> <minus> 		: "ī"   U012B # LATIN SMALL LETTER I WITH MACRON
>  <dead_breve> <I>                 	: "Ĭ"   U012C # LATIN CAPITAL LETTER I WITH BREVE
>  <Multi_key> <U> <I>              	: "Ĭ"   U012C # LATIN CAPITAL LETTER I WITH BREVE
> +<Multi_key> <u> <I>              	: "Ĭ"   U012C # LATIN CAPITAL LETTER I WITH BREVE
>  <Multi_key> <b> <I>              	: "Ĭ"   U012C # LATIN CAPITAL LETTER I WITH BREVE
>  <dead_breve> <i>                 	: "ĭ"   U012D # LATIN SMALL LETTER I WITH BREVE
>  <Multi_key> <U> <i>              	: "ĭ"   U012D # LATIN SMALL LETTER I WITH BREVE
> +<Multi_key> <u> <i>              	: "ĭ"   U012D # LATIN SMALL LETTER I WITH BREVE
>  <Multi_key> <b> <i>              	: "ĭ"   U012D # LATIN SMALL LETTER I WITH BREVE
>  <dead_ogonek> <I>                	: "Į"   U012E # LATIN CAPITAL LETTER I WITH OGONEK
>  <Multi_key> <semicolon> <I>      	: "Į"   U012E # LATIN CAPITAL LETTER I WITH OGONEK
> @@ -1074,9 +1082,11 @@ XCOMM Part 3
>  <Multi_key> <o> <minus>         	: "ō"   U014D # LATIN SMALL LETTER O WITH MACRON
>  <dead_breve> <O>                 	: "Ŏ"   U014E # LATIN CAPITAL LETTER O WITH BREVE
>  <Multi_key> <U> <O>              	: "Ŏ"   U014E # LATIN CAPITAL LETTER O WITH BREVE
> +<Multi_key> <u> <O>              	: "Ŏ"   U014E # LATIN CAPITAL LETTER O WITH BREVE
>  <Multi_key> <b> <O>              	: "Ŏ"   U014E # LATIN CAPITAL LETTER O WITH BREVE
>  <dead_breve> <o>                 	: "ŏ"   U014F # LATIN SMALL LETTER O WITH BREVE
>  <Multi_key> <U> <o>              	: "ŏ"   U014F # LATIN SMALL LETTER O WITH BREVE
> +<Multi_key> <u> <o>              	: "ŏ"   U014F # LATIN SMALL LETTER O WITH BREVE
>  <Multi_key> <b> <o>              	: "ŏ"   U014F # LATIN SMALL LETTER O WITH BREVE
>  <dead_doubleacute> <O>           	: "Ő"   U0150 # LATIN CAPITAL LETTER O WITH DOUBLE ACUTE
>  <Multi_key> <equal> <O>          	: "Ő"   U0150 # LATIN CAPITAL LETTER O WITH DOUBLE ACUTE
> @@ -1181,6 +1191,7 @@ XCOMM Part 3
>  <Multi_key> <u> <minus> 		: "ū"   U016B # LATIN SMALL LETTER U WITH MACRON
>  <dead_breve> <U>                 	: "Ŭ"   U016C # LATIN CAPITAL LETTER U WITH BREVE
>  <Multi_key> <U> <U>              	: "Ŭ"   U016C # LATIN CAPITAL LETTER U WITH BREVE
> +<Multi_key> <u> <U>              	: "Ŭ"   U016C # LATIN CAPITAL LETTER U WITH BREVE
>  <Multi_key> <b> <U>              	: "Ŭ"   U016C # LATIN CAPITAL LETTER U WITH BREVE
>  <dead_breve> <u>                 	: "ŭ"   U016D # LATIN SMALL LETTER U WITH BREVE
>  <Multi_key> <U> <u>              	: "ŭ"   U016D # LATIN SMALL LETTER U WITH BREVE
> -- 
> 1.7.0.4
> 
> 
> From 7180b06b4157cb79001d575e13a6f68f101fc346 Mon Sep 17 00:00:00 2001
> From: Benno Schulenberg <bensberg at justemail.net>
> Date: Fri, 11 Jan 2013 23:14:20 +0100
> Subject: [PATCH 3/3] Compose: Add composing of Abreve and abreve via breve key, as in iso8859-2.
> 
> Signed-off-by: Benno Schulenberg <bensberg at justemail.net>
> ---
>  nls/en_US.UTF-8/Compose.pre |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/nls/en_US.UTF-8/Compose.pre b/nls/en_US.UTF-8/Compose.pre
> index e6b5d24..37246ac 100644
> --- a/nls/en_US.UTF-8/Compose.pre
> +++ b/nls/en_US.UTF-8/Compose.pre
> @@ -814,11 +814,15 @@ XCOMM Part 3
>  <Multi_key> <U> <A>              	: "Ă"   U0102 # LATIN CAPITAL LETTER A WITH BREVE
>  <Multi_key> <u> <A>              	: "Ă"   U0102 # LATIN CAPITAL LETTER A WITH BREVE
>  <Multi_key> <b> <A>              	: "Ă"   U0102 # LATIN CAPITAL LETTER A WITH BREVE
> +<Multi_key> <breve> <A>              	: "Ă"   U0102 # LATIN CAPITAL LETTER A WITH BREVE
> +<Multi_key> <A> <breve>              	: "Ă"   U0102 # LATIN CAPITAL LETTER A WITH BREVE
>  <Multi_key> <A> <parenleft> 		: "Ă"   U0102 # LATIN CAPITAL LETTER A WITH BREVE
>  <dead_breve> <a>                 	: "ă"   U0103 # LATIN SMALL LETTER A WITH BREVE
>  <Multi_key> <U> <a>              	: "ă"   U0103 # LATIN SMALL LETTER A WITH BREVE
>  <Multi_key> <u> <a>              	: "ă"   U0103 # LATIN SMALL LETTER A WITH BREVE
>  <Multi_key> <b> <a>              	: "ă"   U0103 # LATIN SMALL LETTER A WITH BREVE
> +<Multi_key> <breve> <a>              	: "ă"   U0103 # LATIN SMALL LETTER A WITH BREVE
> +<Multi_key> <a> <breve>              	: "ă"   U0103 # LATIN SMALL LETTER A WITH BREVE
>  <Multi_key> <a> <parenleft> 		: "ă"   U0103 # LATIN SMALL LETTER A WITH BREVE
>  <dead_ogonek> <A>                	: "Ą"   U0104 # LATIN CAPITAL LETTER A WITH OGONEK
>  <Multi_key> <semicolon> <A>      	: "Ą"   U0104 # LATIN CAPITAL LETTER A WITH OGONEK
> -- 
> 1.7.0.4
> 
> 
> From 69a53304c017e3347b19924107160a1db3dd9fa1 Mon Sep 17 00:00:00 2001
> From: Benno Schulenberg <bensberg at justemail.net>
> Date: Fri, 11 Jan 2013 23:00:11 +0100
> Subject: [PATCH 1/3] Compose: Fix a comment.
> 
> Signed-off-by: Benno Schulenberg <bensberg at justemail.net>
> ---
>  nls/en_US.UTF-8/Compose.pre |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/nls/en_US.UTF-8/Compose.pre b/nls/en_US.UTF-8/Compose.pre
> index de24dad..2ee73d6 100644
> --- a/nls/en_US.UTF-8/Compose.pre
> +++ b/nls/en_US.UTF-8/Compose.pre
> @@ -30,7 +30,7 @@ XCOMM Spacing versions of dead accents
>  <dead_abovedot> <dead_abovedot>  	: "˙"   abovedot # DOT ABOVE
>  <dead_diaeresis> <dead_diaeresis> 	: "¨"   diaeresis # DIAERESIS
>  <Multi_key> <quotedbl> <quotedbl> 	: "¨"   diaeresis # DIAERESIS
> -<dead_diaeresis> <space>         	: "\""   quotedbl # REVERSE SOLIDUS
> +<dead_diaeresis> <space>         	: "\""   quotedbl # QUOTATION MARK
>  <dead_doubleacute> <space>       	: "˝"   U2dd # DOUBLE ACUTE ACCENT
>  <dead_doubleacute> <dead_doubleacute> 	: "˝"   U2dd # DOUBLE ACUTE ACCENT
>  <dead_caron> <space>             	: "ˇ"   caron # CARON
> -- 
> 1.7.0.4

-- 
http://www.fastmail.fm - Same, same, but different...



More information about the xorg-devel mailing list