[PATCH][vmware] build: add explicit option to enable/disable VMWGFX

[Gaetan Nadon]

On 13-09-13 10:33 AM, Julien Cristau wrote:
> On Fri, Sep 13, 2013 at 09:08:22 +0100, Burton, Ross wrote:
>
>> On 13 September 2013 06:01, Jakob Bornecrantz <wallbraker at gmail.com> wrote:
>>> If I'm reading this correctly this will cause the build to fail if
>>> you don't give it the disable flag if xatracker is missing?
>>> I'm on the fence if we want this, is this a problem you have
>>> run into?
>> Correct, defaults to enabled and will fail if the dependencies are not
>> present.  If required I could add an "auto" option alongside the
>> explicit on and off options.
>>
>> As a best practise our metadistro (Yocto Project) avoids
>> auto-detection because it leads to undeterministic builds: one day the
>> build order changes and if you forgot an explicit dependency, the
>> compilation changes.
>>
> That makes sense for distros, but I think autodetection should still be
> the default.

I agree with Julien. Generally speaking (I don't know the details of the
current situation), a module should be able to configure (out of the
box) on the largest number of platforms with their usual installed features.

Project policies should be enforced using --with/without and
--enable/disable configuration options rather than tweaking default
values or not supplying them. This adds the benefit of
self-documentation. Multiple projects may have mutually exclusive
requirements when it comes to dependencies.

As a guideline, a module should be able to configure and compile
successfully on the major platforms supported by X as listed in the
release notes.



>
> Cheers,
> Julien
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>