[PATCH] xf86VGAarbiter,vgaHW: Only wrap co-operating VGA drivers

[Daniel Stone]

Hi,

On 12 September 2013 07:37, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> The approach taken in this patch is to first only enable VGA arbitration
> for drivers that require VGA resources. This is detected by moving the
> initialisation from the common xf86 code to the vgaHW module. This is
> strictly an ABI break as any driver that directly uses VGA (i.e. without
> using the vgaHW module) will need to make its own declaration of intent.
> Secondly, we then only wrap the operations with vgaarb get/put for the
> drivers that require VGA access. If we only have a single driver
> requring VGA access, we just wrap Enter/LeaveVT and lock the VGA
> arbiter for the entire duration that the Xserver is active.

Why not add a new HW_NO_VGA flag to the GET_REQUIRED_HW_INTERFACES
driverFunc() call, thus skipping the ABI break? Or flip the sense of
your additional call, making it use VGA unless you opt out.

Cheers,
Daniel