[PATCH 1/3] bs: Set the screen's bs support level to WhenMapped not Always

[Ville Syrjälä]

On Thu, Sep 12, 2013 at 12:04:13PM -0400, Adam Jackson wrote:
> Since we're using RedirectAutomatic to do this, we don't actually
> preserve contents when unmapped.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  dix/window.c                   | 2 +-
>  hw/xfree86/common/xf86Helper.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/dix/window.c b/dix/window.c
> index 9fa51c2..1bd7d8b 100644
> --- a/dix/window.c
> +++ b/dix/window.c
> @@ -530,7 +530,7 @@ CreateRootWindow(ScreenPtr pScreen)
>      if (disableBackingStore)
>          pScreen->backingStoreSupport = NotUseful;
>      if (enableBackingStore)
> -        pScreen->backingStoreSupport = Always;
> +        pScreen->backingStoreSupport = WhenMapped;

So if you start the server w/ +bs it will report backing store as
supported even if the composite extension is never initialized?

>  
>      pScreen->saveUnderSupport = NotUseful;
>  
> diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c
> index 721159d..4f1f3d4 100644
> --- a/hw/xfree86/common/xf86Helper.c
> +++ b/hw/xfree86/common/xf86Helper.c
> @@ -1640,7 +1640,7 @@ xf86SetBackingStore(ScreenPtr pScreen)
>              from = X_CONFIG;
>      }
>      free(options);
> -    pScreen->backingStoreSupport = useBS ? Always : NotUseful;
> +    pScreen->backingStoreSupport = useBS ? WhenMapped : NotUseful;
>      if (serverGeneration == 1)
>          xf86DrvMsg(pScreen->myNum, from, "Backing store %s\n",
>                     useBS ? "enabled" : "disabled");
> -- 
> 1.8.3.1
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel

-- 
Ville Syrjälä
syrjala at sci.fi
http://www.sci.fi/~syrjala/