[PATCH 2/3] composite: Automatically enable backing store support on the screen

Peter Harris pharris at opentext.com
Thu Sep 12 10:14:14 PDT 2013


For the series,
Reviewed-by: Peter Harris <pharris at opentext.com>

One minor bikeshed-coloured nit:

On 2013-09-12 12:04, Adam Jackson wrote:
>              compRedirectWindow(serverClient, pWin, CompositeRedirectAutomatic);
>              pWin->backStorage = (pointer) (intptr_t) 1;
> -        }
> -        else {
> +        } else {
>              compUnredirectWindow(serverClient, pWin,
>                                   CompositeRedirectAutomatic);
>              pWin->backStorage = NULL;

This hunk undoes the "-nce" flag passed to indent.
http://cgit.freedesktop.org/xorg/util/modular/tree/x-indent.sh#n12

I prefer -ce myself, so I'd rather see a patch to x-indent.sh than the
removal of this hunk, but I didn't speak up fast enough at the time.

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the xorg-devel mailing list