[PATCH 2/3] damageext: Add damageext.h to sources

Alan Coopersmith alan.coopersmith at oracle.com
Wed Sep 11 17:16:01 PDT 2013


On 09/11/13 02:26 PM, Adam Jackson wrote:
> Apparently this has never been in the release tarballs?  Wild.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>   damageext/Makefile.am | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/damageext/Makefile.am b/damageext/Makefile.am
> index 4d4cf44..35f7620 100644
> --- a/damageext/Makefile.am
> +++ b/damageext/Makefile.am
> @@ -4,4 +4,5 @@ AM_CFLAGS = $(DIX_CFLAGS)
>
>   libdamageext_la_SOURCES = 	\
>   	damageext.c		\
> +	damageext.h		\
>   	damageextint.h

git grep shows nothing #include it either, and it's contents simply duplicate
the DamageExtensionInit() prototype that's now been added to include/extinit.h
by commit a1d41e311c21eb66.

It looks like Daniels removed that line from the Makefile.am in a1d41e311c21eb66
but forgot to git rm the file in that commit.

Is there any reason to keep the file and not just delete it?

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list