[PATCH 5/7] damage: Micro-tune the ReportNonEmpty case
Adam Jackson
ajax at redhat.com
Mon Sep 9 09:08:14 PDT 2013
On Tue, 2013-09-03 at 18:54 +0100, Chris Wilson wrote:
> On Mon, Sep 02, 2013 at 10:19:00AM -0400, Adam Jackson wrote:
> > gcc doesn't seem to be smart enough to short-circuit the RegionUnion
> > call when the region was previously empty. Possibly this was partly
> > that the second argument to RegionUnion() isn't const.
> >
> > Signed-off-by: Adam Jackson <ajax at redhat.com>
>
> After this patch, we only record the first damage event, and not the
> cumulative pDamage->damage, which would seem to break the API.
> -Chris
Mmm, yeah. That would break the protocol too since Subtract would no
longer re-emit the right region. Fair enough, ignore this one.
- ajax
More information about the xorg-devel
mailing list