[PATCH 7/7] damageext: Xineramify

[Eric Anholt]

Adam Jackson <ajax at redhat.com> writes:

> Probable issues:
>
> Pixmaps will get N times as many reports as they should; they're
> replicated to all screens, so.
>
> Windows will have funny-looking seams in the damage report.

Isn't this missing translation for the regions between the client's
damage record and the damage record for windows on the root pixmap?
Looking at, say, PanoramiXPolyFillRectangle, there's:

    isRoot = IS_ROOT_DRAWABLE(draw);
    ...
            if (isRoot) {
                int x_off = screenInfo.screens[j]->x;
                int y_off = screenInfo.screens[j]->y;
                ...
            }

Also, the global for redirecting the per-screen creates to the client's
drawable looked goofy, but I suspect once you solve the translation
thing, that will have gone away.

Patch 5 looked wrong, as noted by Chris.  So, assuming the little
cleanup I noted on #2, patches 1, 2, 3, 4, and 6 are:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130903/17fdfe9e/attachment.pgp>