[PATCH xwayland] xwayland: Just send the bounding box of the damage

Daniel Stone daniel at fooishbar.org
Thu Oct 31 00:14:49 CET 2013


On 30 October 2013 21:31, Adam Jackson <ajax at redhat.com> wrote:
> ... instead of every rect.  Most window updates are going to be CopyArea
> in from offscreen, with plenty of time to get back around to
> BlockHandler in between, so this is no change there.  However for
> pathological apps like x11perf that draw complicated primitives directly
> to the window you can end up with massive numbers of damage rects, and
> you can run out of space in the write buffer and crash.
> This obviously isn't a complete fix, and it would be nice to handle this
> more gracefully in the wayland client code, but this at least lets
> x11perf -all run to completion.
> While we're in the area, rearrange attach to be before damage, not
> after, since the spec says that's the correct order.
> Signed-off-by: Adam Jackson <ajax at redhat.com>

Given the CopyArea-from-pixmap thing as the dominant usecase:
Reviewed-by: Daniel Stone <daniel at fooishbar.org>


More information about the xorg-devel mailing list