[PATCH synaptics] Prevent button mashing on clickpads

[Peter Hutterer]

On Sun, Oct 27, 2013 at 04:24:47PM -0700, Daniel Colascione wrote:
> The tiny patch below disables the clickpad hardware "button" when
> syndaemon has asked us to disable tapping.  Without this patch, I
> frequently find myself accidentally clicking while typing.

isn't this a physical button? if so, it'd be better to just disable the
touchpad fully instead of just disabling tapping.

Cheers,
   Peter



> 
> Index: src/synaptics.c
> ===================================================================
> --- src/synaptics.c	2013-10-27 01:52:44.586863030 -0700
> +++ src/synaptics.c	2013-10-27 01:52:53.442862768 -0700
> @@ -2797,6 +2797,11 @@
>          return delay;
>      }
> 
> +    /* If we have a clickpad and we've been asked to disable taps,
> +     * also pretend the hardware button isn't pressed. */
> +    if (para->touchpad_off == TOUCHPAD_TAP_OFF && para->clickpad)
> +        hw->left = hw->middle = hw->right = FALSE;
> +
>      /* We need both and x/y, the driver can't handle just one of the two
>       * yet. But since it's possible to hit a phys button on non-clickpads
>       * without ever getting motion data first, we must continue
> with 0/0 for
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>