[PATCH 3/3] mieq: Bump default queue size to 512

[Jasper St. Pierre]

Reviewed-by: Jasper St. Pierre <jstpierre at mecheye.net>


On Tue, Oct 29, 2013 at 12:09 PM, Adam Jackson <ajax at redhat.com> wrote:

> Based on some bugzilla scraping I did around November 2012.  Of xserver
> bugs in Red Hat bugzilla with an EQ size message in the log, the
> distribution looked like:
>
> String                      | Matches
> -------------------------------------
> Increasing EQ size to 512   | 460
> Increasing EQ size to 1024  | 52
> Increasing EQ size to 2048  | 6
> Increasing EQ size to 4096  | 0
>
> Most of the "512" ones appear to be mostly harmless, some relatively
> expensive path in either rendering or resource destruction simply taking
> too long due to external pressures like paging or CPU contention.  So
> let's raise the initial queue size, both to reduce the number of
> spurious abrt reports and to drop fewer events in all but the most
> pathological cases.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  mi/mieq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mi/mieq.c b/mi/mieq.c
> index d7d73de..4c07480 100644
> --- a/mi/mieq.c
> +++ b/mi/mieq.c
> @@ -60,7 +60,7 @@ in this Software without prior written authorization
> from The Open Group.
>  #endif
>
>  /* Maximum size should be initial size multiplied by a power of 2 */
> -#define QUEUE_INITIAL_SIZE                 256
> +#define QUEUE_INITIAL_SIZE                 512
>  #define QUEUE_RESERVED_SIZE                 64
>  #define QUEUE_MAXIMUM_SIZE                4096
>  #define QUEUE_DROP_BACKTRACE_FREQUENCY     100
> --
> 1.8.3.1
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>



-- 
  Jasper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131029/33fc6113/attachment.html>