[PATCH 6/7] sync: always set the brackets (#59644)

Keith Packard keithp at keithp.com
Thu Oct 17 23:31:25 PDT 2013

Peter Hutterer <peter.hutterer at who-t.net> writes:

> This patch changes the behavior, so that the brackets are always the nearest
> positive or negative transitions to the current counter value. In the example
> above, nt will trigger a wakeup and a re-calculation of the brackets, so that
> going past it in the negative direction will then cause the proper alarm
> triggers.

I couldn't quite figure out Peter's example, but I do understand the
patch and it looks correct. It fixes cases like:

        Timer currently past a positive trigger

                No bracket values, because no trigger in range

        Timer moves backwards before the positive trigger

                Brackets not reset, even though there is now a trigger
                in range

        Timer moves forward past the positive trigger

                Trigger doesn't fire because brackets not set
Setting the LT bracket in this case will cause everything to get
re-evaluated when the sync value moves backwards before the trigger

Reviewed-by: Keith Packard <keithp at keithp.com>

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131017/a5157d74/attachment.pgp>

More information about the xorg-devel mailing list