[PATCH 3/7] mi: Remove questionable optimization from the rootless path

Adam Jackson ajax at redhat.com
Thu Oct 17 10:30:09 PDT 2013

This is effectively a revert of 7b506fdc840aebed6b5acb91437a2cb620b5bddc
except the coding style reindent broke that.  The code makes no sense in
any case.  drawable can never be null since it's the first member of
WindowRec, and we're never called with a null window.  Neither can it be
an UNDRAWABLE_WINDOW since those are InputOnly windows; the rootless
code does not set the root window to either UNDRAWABLE or InputOnly, so.

Reviewed-by: Jasper St. Pierre <jstpierre at mecheye.net>
Signed-off-by: Adam Jackson <ajax at redhat.com>
 mi/miexpose.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/mi/miexpose.c b/mi/miexpose.c
index 8b7c93f..115f6b0 100644
--- a/mi/miexpose.c
+++ b/mi/miexpose.c
@@ -519,9 +519,6 @@ miPaintWindow(WindowPtr pWin, RegionPtr prgn, int what)
     DrawablePtr drawable = &pWin->drawable;
 #ifdef ROOTLESS
-    if (!drawable || drawable->type == UNDRAWABLE_WINDOW)
-        return;
     if (IsFramedWindow(pWin)) {
         RootlessDamageRegion(pWin, prgn);

More information about the xorg-devel mailing list